On Sun, Jul 27, 2014 at 01:32:51PM +0200, Fabian Keil wrote:
> Dan Fandrich <dan_at_coneharvesters.com> wrote:
> > On Fri, Jul 04, 2014 at 03:38:39PM +0200, Fabian Keil wrote:
> >
> > > Subject: [PATCH 1/6] Allow to overwrite $TESTDIR through the environment
> >
> > This one seems like it could be useful. I would prefer that the environment
> > variable be less generic; something with a CURL prefix would be better.
>
> Agreed. Attached is an updated version that uses CURL_TESTDIR instead.
> Any other name is fine with me, too.

After thinking about this one, it seems that there's no reason to use a magic
environment variable for this, but rather a normal command-line option. Do you
see a reason this couldn't be implemented that way?

>
> > > Subject: [PATCH 2/6] runtests.pl: Let runhttpserver() use $TESTDIR instead of
> > > $srcdir
> >
> > It seems that this one must be combined with the first in order to maintain a
> > working test system.
>
> It should work independently. $TESTDIR defaults to $srcdir/data
> therefore $TESTDIR/.. equals $srcdir.

I misread the second as reading the environment variable TESTDIR and not the
perl variable...

> > > tests: Make sure the weekday in Date headers matches the date
> >
> > A reasonable idea. But, there should probably be a test added with a
> > deliberate weekday/date mismatch to ensure that libcurl still works
> > with that combination.
>
> Test attached. My impression was that curl doesn't parse the
> Date header, but I agree that testing that it behaves as expected
> is a good idea anyway.

All the test currently does is verify that libcurl doesn't crash if the date is
invalid. Better would be a test that validates that the date is parsed
correctly (i.e. ignoring the day-of-week), maybe something based on test 77.

> I also attached a patch to align the -l output again.

Applied.

>>> Dan
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-08-07