cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH 3/5] Don't clear GSSAPI state between each exchange in the negotiation

From: Michael Osipov <1983-01-06_at_gmx.net>
Date: Sat, 12 Jul 2014 20:43:11 +0200

Am 2014-07-11 13:29, schrieb David Woodhouse:
> From: David Woodhouse <David.Woodhouse_at_intel.com>
>
> GSSAPI doesn't work very well if we forget everything ever time.
>
> XX: Is Curl_http_done() the right place to do the final cleanup?
> ---
> lib/http.c | 4 ++++
> lib/http_negotiate.c | 1 -
> lib/http_negotiate_sspi.c | 1 -
> 3 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/http.c b/lib/http.c
> index 78791ee..249da0f 100644
> --- a/lib/http.c
> +++ b/lib/http.c
> @@ -1443,6 +1443,10 @@ CURLcode Curl_http_done(struct connectdata *conn,
>
> Curl_unencode_cleanup(conn);
>
> + if (data->state.proxyneg.state == GSS_AUTHSENT ||
> + data->state.negotiate.state == GSS_AUTHSENT)
> + Curl_cleanup_negotiate(data);

That does not compile without GSS-API. You forgot the #ifdef HAVE_GSSAPI.

I am on my way cleaning out stuff. It compiles now.

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-07-12