cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] tests: run NTLM tests even if symbols hiding is enabled

From: Kamil Dudka <kdudka_at_redhat.com>
Date: Wed, 11 Jun 2014 13:01:50 +0200

On Tuesday, June 10, 2014 20:23:44 Alessandro Ghedini wrote:
> On Sun, May 25, 2014 at 12:43:53PM +0200, Alessandro Ghedini wrote:
> > This is a follow-up to [0], and it basically enables the NTLM tests even
> > if
> > symbol hiding is enabled (i.e. without the need to pass
> > --disable-symbol-hiding to configure).
> >
> > If you run make check now you'll see a bunch of NTLM tests failing. I've
> > run a quick bisect and it seems that the commit that introduced the
> > breakage is:
> >
> > 86724581b6c02d160b52f817550cfdfc9c93af62 is the first bad commit
> > commit 86724581b6c02d160b52f817550cfdfc9c93af62
> > Author: Prash Dush <pradush123_at_gmail.com>
> > Date: Fri Jan 24 13:01:29 2014 +0000
> >
> > ntlm: Added support for NTLMv2
> > :
> > :040000 040000 f4d3be3ff96a3e5e1c7d092d5ea2a11b80b90f3c
> > :fbf3786792f24453ec63cfc197464c49c1fec527 M lib>
> > I'm not sure what's the best way to fix this though.
>
> I kinda forgot about this, so... ping?

I also ended up with the above commit while running git-bisect on curl. The
problem is that NTLM tests are now supported only with a debug build of curl
and there is no plan to change it:

https://github.com/bagder/curl/commit/0e113070#commitcomment-5711089

Kamil
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-06-11