You are right. I can successfully build the dll from the daily snapshot. But I'm not sure if it's all right to compile src/tool_cb_rea.c without having defined BUILDING_WARNLESS_C, while we have it defined when compiling lib/warnless.c. Because src/tool_cb_rea.c includes lib/warnless.h (through curlx.h), which doesn't define it, but uses the read() function, inside tool_read_cb(). On the other hand, lib/warnless.c defines it for itself. BUILDING_WARNLESS_C only really matters when compiling warnless.h, the only one that contains the preprocessor directives that test BUILDING_WARNLESS_C and redefine functions. >________________________________ > From: Daniel Stenberg <daniel_at_haxx.se> >To: Mihai Hanor <mhanor_at_yahoo.com>; libcurl development <curl-library_at_cool.haxx.se> >Cc: "webmaster_at_confusedbycode.com" <webmaster_at_confusedbycode.com> >Sent: Sunday, April 13, 2014 9:13 PM >Subject: Re: Unable to build dll version of curl 7.36.0 on Windows > > >On Sun, 13 Apr 2014, Mihai Hanor wrote: > > >> Building the dll version of curl 7.36.0 (MSVC 10), on Windows, fails when >> linking, with this error message: tool_cb_rear.obj : error LNK2019: >> unresolved external symbol curlx_read referenced in function tool_read_cb >> >> As I see it, BUILDING_WARNLESS_C should be defined in lib/warnless.h, not in >> lib/warnless.c. At least, with this modification, I can successfully build >> the dll. The affected file in the git repository is unchanged in this >> regard, so I assume this is not fixed. > >It _is_ fixed in git, just possibly not the same way you did it. I'm of course >interested in getting to know if it somehow isn't complete... > >-- > >  / daniel.haxx.se > > > >

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-04-13