Hi all

In addition to working on Visual Studio project files at the moment I had also started work on adding DIGEST-MD5 support using Windows SSPI rather than the native routines.

As such, I managed to get this working in the wee small hours of Saturday morning and have been pushing various commits (and fix ups – sorry about that!) over the couple 24 hours.

However, I would appreciate a quick code review of where I have used the hostname from the data->easy_conn->host in curl_sasl_sspi.c:113 as it doesn’t appear to work under the test suite given that one of the tests generated the following response message:

username="user",realm="",nonce="5300d17a1d695bd411e4cdf96f9548c23ced6175",digest-uri="imap/�=2",cnonce="56cd5d19c0a45e216795a487070426ef",nc=00000001,response=2701b59ff4007c594656cf50fcdef9ee,qop=auth

As can be seen the uri is corrupt :(

This can been seen in Test 823 from the following auto build:

http://curl.haxx.se/dev/log.cgi?id=20140406130453-5380#prob34

Is this just a small quirk of the test suite or is it best to use the host name from the conndata structure?

As a side note this test shouldn't be running under SSPI now, like the NTLM tests, and I am currently in the process of fixing them up but can this (presumably null) hostname happen in the real world and do I need to rework this area of code?

Kind Regards

Steve

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-04-06