cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [RELEASE] curl and libcurl 7.36.0

From: Kamil Dudka <kdudka_at_redhat.com>
Date: Wed, 26 Mar 2014 22:03:50 +0100

On Wednesday, March 26, 2014 21:34:27 Alessandro Ghedini wrote:
> On mer, mar 26, 2014 at 08:39:09 +0100, Daniel Stenberg wrote:
> > On Wed, 26 Mar 2014, Alessandro Ghedini wrote:
> > >So, I've been trying to build curl 7.36.0 but I'm seeing a whole lot of
> > >test failures all related to NTLM (067 068 069 081 089 090 091 150 155
> > >159
> > >169 209 213 239 243 265 267 547 548 555 590).
> >
> > Can you show me your configure options ?
>
> ./configure --enable-threaded-resolver --with-ca-path=/etc/ssl/certs \
> --disable-dependency-tracking --disable-symbol-hiding \
> --enable-versioned-symbols --with-lber-lib=lber --with-gssapi=/usr
>
> I've noticed that if I remove the "--disable-symbol-hiding" option, the NTLM
> tests are not run (which is kinda weird).

I suspect this was caused by the following commit:

https://github.com/bagder/curl/commit/83a42ee2

I was able to reduce the diff to a work-in-progress patch:

--- a/tests/libtest/sethostname.h
+++ b/tests/libtest/sethostname.h
@@ -31,7 +31,11 @@
 #elif defined(BUILDING_LIBCURL) && defined(CURL_HIDDEN_SYMBOLS)
 # define LIBHOSTNAME_EXTERN CURL_EXTERN_SYMBOL
 #else
-# define LIBHOSTNAME_EXTERN
+# ifdef CURL_HIDDEN_SYMBOLS
+# define LIBHOSTNAME_EXTERN CURL_EXTERN_SYMBOL
+# else
+# define LIBHOSTNAME_EXTERN
+# endif
 #endif

 #ifdef USE_WINSOCK

... but did not find enough time to write the proper fix for this once
I realized that the tests would run only in a debug build anyway.

Kamil
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-03-26