cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: FTP wildcard problem

From: Justin Maggard <jmaggard10_at_gmail.com>
Date: Mon, 3 Mar 2014 15:33:00 -0800

On Sun, Mar 2, 2014 at 2:56 AM, Pavel Raiskup <praiskup_at_redhat.com> wrote:
>> I'm using the wildcard matching functionality of libcurl to do
>> recursive FTP backups, and I've run into a problem. Each time I hit
>> an empty directory, then next call to curl_easy_perform() just quits
>> immediately. This following simple patch makes it work for me, by not
>> considering an empty wildcard match an error, but this may not be the
>> correct approach. Any thoughts?
>
> thanks for the report. Are you testing against git master branch? From a
> very quick observation, it seems to me that this (or at least similar)
> issue was fixed by Dan:
>
> commit c631a54bb60b2bbaf5085a679ce140330158d513 (HEAD, refs/bisect/bad)
> Author: Dan Fandrich <dan_at_coneharvesters.com>
> AuthorDate: Wed Jan 29 22:40:57 2014 +0100
>
> ftp: fixed a memory leak on wildcard error path
>

You're right, that does indeed fix it. Sorry for the false alarm; I
was testing 7.35.0. I did read through the git log since 7.35.0, but
none of the descriptions sounded like they were related. I'll be sure
to try git master next time.

-Justin
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-03-04