On Wed, 12 Feb 2014, Dan Fandrich wrote:

>> bool canPipeline = IsPipeliningPossible(data, needle);
>> - bool wantNTLM = (data->state.authhost.want & CURLAUTH_NTLM) ||
>> - (data->state.authhost.want & CURLAUTH_NTLM_WB) ? TRUE : FALSE;
>> + bool wantNTLMhttp = ((data->state.authhost.want & CURLAUTH_NTLM) ||
>> + (data->state.authhost.want & CURLAUTH_NTLM_WB)) &&
>> + (needle->handler->protocol & CURLPROTO_FTP) ? TRUE : FALSE;
>
> I haven't tried the patch, but I don't follow this logic--shouldn't that be
> & CURLPROTO_HTTP? The check for FTP is done again below.

Yes it should indeed. Thanks for reviewing it correctly!

> And on a side note, is there really some compiler that complains if the
> ?TRUE:FALSE is omitted? Is seems pretty clunky.

Those are mostly the results Yang cleanups at some point I believe. I'm not
aware of the rationalisation for when or if they are truly needed.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html