On Wed, Feb 12, 2014 at 1:14 AM, <curl-library-request_at_cool.haxx.se> wrote:
> Now this change is very curious to me. Isn't curl_off_t a full 64bit type for
> you on mingw?

According to config.status:
D["CURL_TYPEOF_CURL_OFF_T"]=" int64_t"
D["CURL_FORMAT_CURL_OFF_T"]=" \"I64d\""
D["CURL_FORMAT_CURL_OFF_TU"]=" \"I64u\""
D["CURL_FORMAT_OFF_T"]=" \"%I64d\""
D["CURL_SIZEOF_CURL_OFF_T"]=" 8"
D["CURL_SUFFIX_CURL_OFF_T"]=" LL"
D["CURL_SUFFIX_CURL_OFF_TU"]=" ULL"

Checking the MinGW headers:
strtoul returns unsigned long
strtoll returns long long

limits.h has
ULONG_MAX 0xffffffffUL
LLONG_MAX 9223372036854775807LL

Checking the runtime library, strtoll appears to call a function
called strtoimax. I checked the version of MinGW I'm using the latest
mingw runtime library and the mingw64 runtime library and they are all
calling the exact same routine. The routine uses INTMAX_MAX which is
set in stdint.h as 9223372036854775807LL.

Checking the call to curlx_strtoofft in http_chunks.c when
curlx_strtoofft = strtoll:
errno before calling curlx_strtoofft 34
ch->hexbuffer = 1f43
errno after calling curlx_strtoofft 34

Checking the call to curlx_strtoofft in http_chunks.c when
curlx_strtoofft = strtoul
errno 34
ch->hexbuffer 1f43
errno 0

If I set errno=0 before calling curlx_strtoofft when curlx_strtoofft =
strtoll, it appears to solve the problem. So, it looks like strtoul
is clearing errno and strtoll is not. Didn't dig further to try to
find out why errno was already set before the call. Adding errno=0,
would probably be a better fix that switching back to stroul.

Hope some of this is useful. Thanks for the great job developing curl.

Sincerely,
Laura
http://www.distasis.com/cpp
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-02-12