cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: left for http2

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 5 Feb 2014 10:32:13 +0100 (CET)

On Wed, 5 Feb 2014, Fabian Frank wrote:

> This was almost correct, the thing is that non-compressed responses are
> still allowed and for example https://106.186.112.116/ sends such responses
> and was thus broken. I attached a patch that fixes this, by relying on the
> response header for content encoding.

Thanks, your improvement was also almost correct! =)

We should check that we actually _got_ a http2 response and not only that we
asked for it, as there will be cases when we will be stuck with HTTP1. I
updated your patch slightly before I pushed.

I verified with these commands:

$ curl --http2 https://106.186.112.116/ -k
$ curl --http2 http://106.186.112.116/
$ curl --http2 https://twitter.com/

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2014-02-05