On Tue, 4 Feb 2014, Martín Germán Duarte wrote:

> > 1 - why assign 'want = 2'? we have defines for all the auth >values!

> Because, for the authentication digest the constant CURLAUTH_DIGEST is 2, if
> 'want' is not assign with the allowed values the function pickoneauth always
> return FALSE, this is the main reason of this modification. Before that
> 'want' was assigned with 2, 'want' had not value, so maybe this is a bug
> into the libcurl but I don't know.

Your application needs to tell libcurl it wants authentication and it needs to
specify which method(s). See CURLOPT_HTTPAUTH.

>> 3 - Have you ran the test suite successfully with your patch >applied?
>> It failed already on test 67 when I tried it.

> Yes, with many IP cameras (Axis cameras) and VLC as a RTSP server, and work
> properly.

You're missing my point: your change breaks libcurl in other ways. We can't
have that. All exiting tests must continue to run fine with your changes
applied.

>> 4 - Is 401/407 responses for RTSP really defined to never have a >body?

> I think it is not neccesary

That sounds a bit vague. What exactly does the RTSP spec say about 401 and 407
responses?

>> 5 - Have you tried to add a test case for this in the curl test suite?

> No, I think this is a good a idea, if you want you can do it.

[no comment]

-- 
  / daniel.haxx.se

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-02-04