cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] CURLOPT_PROXYHEADER: send/replace proxy headers only

From: Vijay Panghal <vijay.panghal_at_gmail.com>
Date: Tue, 10 Dec 2013 10:41:42 -0800

Daniel,

I have rebased the patch on 7.34.0-Dev. Please review it and let me know
anything that you want me to fix.

Change summary:
Http Proxy: Option to set header for http proxy.

This commit add support for 'CURLOPT_PROXYHEADER' that sets or replaces
headers only for requests that are sent to a proxy.
Summary of the changes:

(1) Added documentation for new option
(2) Added unit test cases (1513, 1514 and 1515) for the new option
(3) Fix unit test case 1509, that was causing non-deterministic result
    in further unit tests.

Unit test:
TESTDONE: 805 tests out of 805 reported OK: 100%
TESTDONE: 914 tests were considered during 285 seconds.
TESTINFO: 109 tests were skipped due to these restraints:
TESTINFO: "curl lacks Metalink support" 18 times (2005, 2006, 2007, 2008,
2009, 2010, 2011, 2012, 2013 and 9 more)
TESTINFO: "no stunnel" 26 times (300, 301, 302, 303, 304, 305, 306, 307,
308 and 17 more)
TESTINFO: "failed starting SSH server" 12 times (564, 700, 701, 702, 703,
706, 707, 708, 709 and 3 more)
TESTINFO: "no gnutls-serv" 4 times (320, 321, 322, 324)
TESTINFO: "configured as DISABLED" 6 times (594, 815, 816, 1209, 1211, 1512)
TESTINFO: "curl lacks sftp server support" 32 times (582, 583, 600, 602,
604, 606, 608, 609, 610 and 23 more)
TESTINFO: "curl lacks scp server support" 10 times (601, 603, 605, 607,
617, 619, 621, 623, 629 and 1 more)
TESTINFO: "curl lacks sftp support" 1 times (632)

On Sun, Jul 21, 2013 at 1:44 PM, Daniel Stenberg <daniel_at_haxx.se> wrote:

> On Tue, 14 May 2013, Vijay Panghal wrote:
>
> Hi again Vijay,
>
>
> I have added libcurl unit test for the patch. During testing, I found
>> that enabling CURLOPT_PROXYHEADER breaks the searching of http header. To
>> fix this I have made these changes into the patch
>>
>> 1) Added function Curl_checkProxyheaders() to search http proxy header.
>> 2) Replaced the http proxy api call Curl_checkheaders with
>> Curl_checkProxyheaders() where we wants to search into http proxy headers
>>
>> I have added three unit test to regress the changes
>>
>
> I just wanted to mention that I was slowly getting back to this topic and
> I hope to refresh this patch again soon, but I missed the merge window for
> the next release (again).
>
> --
>
> / daniel.haxx.se
>

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2013-12-10