cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Tests 19 and 704 unreliable on FreeBSD after 02fbc26d5 (connect: Add connection delay to Happy Eyeballs)

From: Fabian Keil <freebsd-listen_at_fabiankeil.de>
Date: Sat, 16 Nov 2013 23:32:14 +0100

Steve Holme <steve_holme_at_hotmail.com> wrote:

> On Sat, 16 Nov 2013, Fabian Keil wrote:
>
> > > Can you please confirm if this is the same problem that I mentioned
> here:
> > >
> > > http://curl.haxx.se/mail/lib-2013-11/0110.html
> >
> > I'm reasonable sure about the AIX failures due to the matching:
>
> Thank you - that's much appreciated.

No problem.
 
> > I also ran test 1233 with git master in a loop and can confirm that
> > it's unreliable on FreeBSD as well. It just doesn't fail as often as
> > 19 and 704. The patch seems to fix it, too.
>
> Cool - I think it would be best to fix the issue in singleipconnect() where
> it returns CURLE_COULDNT_CONNECT as I think it will make the code more
> readable and means that sockp doesn't need to be unnecessarily set and
> returned.
>
> If I put together a quick patch - would you be able to test it for me
> please?

I tested the attached patch which should do what you describe and it
works as expected. If I misunderstood, I can also test your version.

Fabian

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2013-11-16