On Wednesday 30 October 2013 17:06:09 Kamil Dudka wrote:
> On Wednesday 30 October 2013 16:14:54 Kamil Dudka wrote:
> > On Wednesday 30 October 2013 09:58:36 Daniel Stenberg wrote:
> > > On Wed, 30 Oct 2013, Steve Holme wrote:
> > > > I've just pushed commit e17c1b25bc33eb.
> > > >
> > > > I will an eye out on the auto builds to see if anything is flagged
> > > > but any comments or feedback is much appreciated.
> > >
> > > It immediately made test 67 fail for me. It seems our NTLM code is
> > > passing in the basee64 string _with_ the trailing CRLF at the end (sent
> > > to the Curl_ntlm_decode_type2_message() function) so the length isn't
> > > an even 4 bytes. In the test case the string is in fact 218 bytes as
> > > the last two aren't part of the base64...
> >
> > The following patch fixes the problem for me.
>
> Oops, my previous patch did not handle the CR character, so NTLM was still
> broken. The attached patch should fix it!

One more follow-up attached.

> > Kamil

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html