cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Compilation warning in ftp.c

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 24 Sep 2013 23:07:10 +0200 (CEST)

On Tue, 24 Sep 2013, Steve Holme wrote:

> The variable "dirlen" is defined as a size_t (unsigned) however,
> curl_easy_unescape() is expecting a signed int. The existing code runs the
> value through curlx_sztosi() which is designed to convert from a signed
> size_t (aka ssize_t) to a signed int. As such the IRIX compiler is whinging
> about it. Now I don't run IRIX or any *nix builds for that matter so I can't
> test my proposed fix on those platforms but my question is.
>
> Should we be using curlx_uztosi() instead of curlx_sztosi() as per my
> proposed and attached fix?

Yes I think so. I think the current code is just an honest mistake. Go ahead
and push I say!

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2013-09-24