cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] curl.h: name space pollution by "enum type"

From: Kamil Dudka <kdudka_at_redhat.com>
Date: Wed, 21 Aug 2013 23:03:51 +0200

On Wednesday, August 21, 2013 22:54:43 Daniel Stenberg wrote:
> Hi all,
>
> We got this bug report (https://github.com/bagder/curl/pull/76) about a name
> space pollution we have in the curl/curl.h public header. It was added by
> me in 47c392e135f17 (Jul 22 2009).
>
> The fix that removes the pollution then also changes the name of an enum we
> provide. I suspect *very* few programs actually use the enum by name so it
> should be very rare that this breaks anything but still...
>
> Any alternative suggestions?
>
> NOTE: my fix is slightly different than the one in the pull request.

Looks good to me.

Kamil
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-08-21