cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH 2/3] src/tool: allow timeouts to accept decimal values

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sun, 14 Jul 2013 22:49:36 +0200 (CEST)

On Sun, 14 Jul 2013, Dave Reisner wrote:

> Implement wrappers around strtod to convert the user argument to a double
> with sane error checking. Use this to allow --max-time and --connect-timeout
> to accept decimal values instead of strictly integers.
>
> The manpage is updated to make mention of this feature and, additionally,
> forewarn that the actual timeout of the operation can vary in its precision
> (particularly as the value increases in its decimal precision).

Thanks!

I previously considered doing this change too and I find your solution for
doing it very nice and clean. The only little thing I'd like to see added is
that the man page should properly clarify from which curl version the decimal
version works.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2013-07-14