cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] configure: explicitly use subdir-objects in automake init

From: Dave Reisner <d_at_falconindy.com>
Date: Mon, 8 Jul 2013 19:05:34 -0400

On Tue, Jul 09, 2013 at 12:31:39AM +0200, Yang Tse wrote:
> On Mon, Jul 8, 2013 at 3:13 PM, Dave Reisner wrote:
>
> > This avoids a large warning on invocation of ./buildconf on automake
> > 1.14:
>
> Commits ecf042ff3c and fe7e3229f8 ensure that configure script is
> generated without using 'subdir-objects' when using automake versions
> older than 1.14 resulting in a configure script functionally identical
> to what was generated up to now.

Well, ok... The subdir-objects option has been around for over a decade.
automake's git repo's first mention of it is 1999 (and I'm sure it
predates that). Whether intended or not, the autotools setup curl uses
is doing what subdir-objects intends to do.

I tested as far as as automake 1.13.1 (don't have any earlier packages
on hand), and subdir-objects works just fine there as well.

> From mentioned commits onwards, when automake 1.14 or newer is used at
> configure script generation time (buildonf) automake initialization
> will make use of 'subdir-objects' and its implications.
>
> Please test using automake 1.14, configure script generation, libcurl
> and curl building and also running testsuite.

Sure. Works for me on 1.14.

> I believe 1Q2013 cleanups and adjustments prepared source code tree
> for this change. In any case, better test thoroughly just in case.
>
> Thanks,
> --
> -=[Yang]=-
> -------------------------------------------------------------------
> List admin: http://cool.haxx.se/list/listinfo/curl-library
> Etiquette: http://curl.haxx.se/mail/etiquette.html
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-07-09