On Mon, Jul 01, 2013 at 07:38:23PM +0100, Markus Moeller wrote:
> This patch adds two new options to set the Kerberos service principal name for
> negotiate authentication. This is useful if you want to access a web server or
> proxy via a secondary interface.
>
> Could you please review and add to the next release ?

This looks like the patch someone wanted almost exactly 6 years ago:
http://curl.haxx.se/mail/archive-2007-07/0053.html Which is an indication of
how much the principal developers use Kerberos--i.e. not much. Which also makes
it difficult to find knowledgeable reviewers.

The patch sounds fine to me, but I'm not one of those mythical knowledgeable
reviewers :-) I noticed what looked like a typo that appeared a couple
of places: kttp. The comments for CURL_DEFAULT_NEGOTIATE_*GSSAPI_SERVICE mention
socks5. Finally, it seems to me that "negotiate" and "gssapi" are really
synonymous in this context, and the options probably don't need both in their
names.

For future revisions, please leave out generated files like tool_hugehelp.c
and please use the curl-library mailing list instead.

>>> Dan
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-07-02