cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] cookie path match fail

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 5 Jun 2013 00:22:38 +0200 (CEST)

On Tue, 4 Jun 2013, YAMADA Yasuharu wrote:

> I apologize that cookie path match patch was incomplete. The patch does not
> support the case that request url path is /hoge?fuga=xxx, this path means
> /hoge/index.cgi?fuga=xxx. The patch could not match received path in neither
> /hoge nor /hoge/.
>
> So, the policy of a new path are:
> - struct Cookie keeps path without most-right '/' except root '/'.
> - compare struct Cookie's path and request uri path without path
> separator, query
> separator or fragment separator.

Thanks! A question about a detail though:

Is the modification of what is stored in the cookie file really necessary? It
will break compatibility with older libcurl versions. And vice versa, will it
work properly to load cookie files written the old way?

A more minor remark is that the check for URL fragments isn't necessary since
they're stripped off from the URL earlier in the process.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2013-06-05