cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] CURLOPT_PROXYHEADER: send/replace proxy headers only

From: Vijay Panghal <vijay.panghal_at_gmail.com>
Date: Tue, 14 May 2013 20:07:51 -0700

Hi Daniel,

I have added libcurl unit test for the patch. During testing, I found that
enabling CURLOPT_PROXYHEADER breaks the searching of http header. To fix
this I have made these changes into the patch

1) Added function Curl_checkProxyheaders() to search http proxy header.
2) Replaced the http proxy api call Curl_checkheaders with
Curl_checkProxyheaders() where we wants to search into http proxy headers

I have added three unit test to regress the changes

test 1512...[Check separate headers are generated
while CURLOPT_PROXYHEADER is present]
-d-pP-e-v OK (1 out of 3 , remaining: 00:13)
test 1513...[Check same headers are generated while CURLOPT_PROXYHEADER is
not present]
-d-pP-e-v OK (2 out of 3 , remaining: 00:04)
test 1514...[Same headers are generated for host and proxy while
CURLOPT_PROXYHEADER is NULL]
-d-pP-e-v OK (3 out of 3 , remaining: 00:00)
TESTDONE: 3 tests out of 3 reported OK: 100%
TESTDONE: 3 tests were considered during 12 seconds.

Regards
Vijay

On Mon, May 6, 2013 at 4:35 AM, Daniel Stenberg <daniel_at_haxx.se> wrote:

> On Sun, 5 May 2013, Vijay Panghal wrote:
>
> Is the patch for proxyheader has been merged in master? if not, is there
>> any plan to merge this into master?
>>
>
> It is not merged, and attached here is a newly rebased version.
>
> It mostly lacks a bunch of test cases now to make sure the documentation
> is accurate and that the code covers most cases. Feel like helping out?
>
> --
>
> / daniel.haxx.se
> -------------------------------------------------------------------
> List admin: http://cool.haxx.se/list/listinfo/curl-library
> Etiquette: http://curl.haxx.se/mail/etiquette.html
>

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2013-05-15