cURL / Mailing Lists / curl-library / Single Mail

curl-library

End bracket typo in lib/connect.c

From: Lars Johannesen <lj_at_halloffame.dk>
Date: Wed, 1 May 2013 07:09:22 +0200

Hello,

First, thanks for curl it is an awesome library that I use daily. But, I
think there might be a bracket typo in lib/connect.c

I should note that I compile curl within the cross-platform toolset mxe,
where I get the following error for curl 7.30.0:
connect.c: In function 'bindlocal':
connect.c:509:13: error: invalid storage class for function 'verifyconnect'
connect.c:575:17: error: invalid storage class for function 'trynextip'
connect.c:626:13: error: invalid storage class for function 'getaddressinfo'
connect.c:831:13: error: invalid storage class for function 'tcpnodelay'
connect.c:940:1: error: invalid storage class for function 'singleipconnect'
connect.c:1170:12: error: invalid storage class for function 'conn_is_conn'
connect.c:1326:1: error: expected declaration or statement at end of input

The configure options are listed here:
https://github.com/tonytheodore/mxe/blob/multi-target/src/curl.mk

I think this is due to an end bracket typo in lib/connect:
422 #ifdef HAVE_SOCKADDR_IN6_SIN6_SCOPE_ID
 423 if(scope_ptr) {
 424 /* The "myhost" string either comes from Curl_if2ip or
 425 from Curl_printable_address. The latter returns only
 426 numeric scope IDs and the former returns none at all.
 427 So the scope ID, if present, is known to be numeric */
 428 si6->sin6_scope_id = atoi(scope_ptr);
 429 }
 430 }
 431 #endif

Where the bracket on 430 should be after the endif, making this change
eliminates the compilation error.

Thanks

Best Regards
Lars

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-05-01