Am 2013-04-10 04:40, schrieb Yang Tse:
> Hi Gün,
>
> On Wed, Apr 10, 2013, Guenter <lists_at_gknw.net> wrote:
>
>> honestly I'm not happy with that hack, and if someone has something better
>> in mind please speak up!
>
> Modify Makefile.m32 in order to make it define one out of three
> possibilities "ENABLE_ARES", "ENABLE_SYNC_DNS" or
> "ENABLE_THREADS_WIN32".
>
> Modify config-win32.h in a way such that when above mentioned macros
> are defined config-win32.h defines appropriate USE_ARES,
> USE_THREADS_WIN32 or none of these two.
>
> This decoupling should also allow to retain default and previous
> behaviour of config-win32.h

I strongly support this approach because its clear and makes everything
explicit. I would even go one step further:

Add an alias for ENABLE_THREADS_WIN32 as ENABLE_ASYNC_DNS if this define
is for DNS only. Threads win22 says absolutely nothing at least to me.

Compile commands could be: mingw32-make mingw32-(ares|adyn|sdyn|dyn)
where dyn == adyn.

This would be fully backward compatible, right?

Mike

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-04-10