cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH ]Cookie sort order not deterministic

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sun, 7 Apr 2013 11:10:27 +0200 (CEST)

On Sun, 7 Apr 2013, Marc Hoersken wrote:

> I noticed that the cookie sort order is not deterministic between platforms
> if there are multiple cookies with the same path (length). This makes
> testcase 62 fail on Windows.

Ack, makes perfect sense to increase determinism so that the test cases work
fine.

I edited the patch slightly, see attachment - bascially I removed two
compiler warnings (see below) and the 'cmp' variable.

I'll push this version soon unless someone objects before that.

cookie.c:788:15: error: conversion to 'int' from 'size_t' may alter its value
[-Werror=conversion]
cookie.c:795:15: error: conversion to 'int' from 'size_t' may alter its value
[-Werror=conversion]

-- 
  / daniel.haxx.se


-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2013-04-07