cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [bagder/curl] e51b23: getpart.pm: Strip carriage returns to fix Windows ...

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sun, 7 Apr 2013 00:36:45 +0200 (CEST)

On Sun, 7 Apr 2013, Daniel Stenberg wrote:

> The test server outputs the directory with LFs only. That's a flaw we should
> fix. ftpserver.pl clearly has the directory stored internally with CRLF
> endings but for some reason the CRs get lost in transition! (I suspect the
> sockfilt handling is to blame...)

After some more testing I'm less certain.

Just doing 'curl ftp://localhost/ -o dump' from my local vsftpd server gives
me a directory listing with LF line endings only...

Still, curl should write to disk what it gets sent.

I did a quick test to try out a modification that allows us to specify the dir
contents in the test file (see attachment for quick proof of concept test),
and if I use this and add CRLF line endings in test 100 I see that curl
doesn't write any to disk. I haven't yet figured out where the bug is.

-- 
  / daniel.haxx.se


-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2013-04-07