cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Curl_raw_toupper - ascii code difference conversion

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sun, 31 Mar 2013 23:26:39 +0200 (CEST)

On Sun, 31 Mar 2013, Anton Barketov wrote:

> I was looking through the source code while working with library and have
> found that Curl_raw_toupper function using huge switch instead of ascii code
> difference conversion. Please look at my patch, as to me it is more shortest
> and easiest way of conversion.

Thanks but...

Shorter? yes.

Faster? Not necessarily.

Easier? Not really since it isn't EBCDIC-compatible anymore as the comment
above helpfully reminds us about.

So therefore I cannot accept it as-is.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2013-03-31