cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH] Addition of trailer headers in HTTP requests generated by libcurl

From: Daniel Stenberg <>
Date: Wed, 13 Mar 2013 22:51:09 +0100 (CET)

On Mon, 11 Mar 2013, Chrysovaladis Datsios wrote:

> changes are in the attached patch.

Thanks. I would say that this is close to getting merged. My main issue is
remark #4 which kind of made #5 slip in...

1 - invalid email in the Author: field

2 - incomplete commit message

3 - transfer.c:245:11: error: conversion to 'int' from 'size_t' may alter its
     value [-Werror=conversion]

4 - lack of test cases. It makes it really hard for us to say that this works
     even in corner cases.

5 - this version still has memory leaks, like if the realloc (on
     transfer.c:228) fails the previous trailer_headers_buf is not freed.

6 - getting the two new options documented

The window for new features is just closed for 7.30.0, but it is looking good
for getting merged when we open it again after that release.

List admin:
Received on 2013-03-13