curl-library
Re: [PATCH] Addition of trailer headers in HTTP requests generated by libcurl
Date: Thu, 28 Feb 2013 12:00:51 +0200
Hi,
I'm sending a patch of my git commited changes (tryed to keep the
indent style, apologize if missed something)
> 3 - I would appreciate a way that starts off with a much smaller buffer but
> that can grow if needed.
Now I start with a buffer of 256 and it grows up to 100K. Added checks for
realloc().
> 4 - Why do you need 'trailer_headers' to be in the connectdata struct? I
> could easily remove it and just have it as a local variable and nothing
> seems to break?
I made it a local slist which is freed when is no longer needed.
> 5 - Please consider a few test cases that proves that your code is working.
I attached a sample code, though I'd like some more suggestions on test cases.
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
- application/octet-stream attachment: 0002-CURLOPT_TRAILERFUNCTION-support-chunked-encoding-req.patch
- text/x-csrc attachment: trailers.c