cURL / Mailing Lists / curl-library / Single Mail

curl-library

tests/libtest/chkhostname.c

From: Gisle Vanem <gvanem_at_broadpark.no>
Date: Fri, 08 Feb 2013 12:15:25 +0100

This is AFAICS the only test program in this directory that doesn't
call curl_global_init(). This function is needed for Curl_gethostname()
to work on Windows at least.

Besides it does a case-sensitive string compare of 'argv[1]' and return
buffer from Curl_gethostname(). Aren't hostnames always compared
with curl_str[n]equal() other places (case-insensitive)?

The "LD_PRELOAD failed" message seems too *nix centric too.

My suggested patch is attached. Patching Makefile.inc should be easy,
but not my cup of tea.

--gv

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2013-02-08