cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH] always multi v5

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Fri, 18 Jan 2013 21:43:47 +0100 (CET)

On Fri, 18 Jan 2013, Steve Holme wrote:

> Whilst reviewing some of my code (the non-blocking ssl connect in pop3.c) I
> got thinking about the xxxx_easy_statemach() functions that exist in ftp.c,
> pop3.c, smtp.c and imap.c
>
> Excuse me if this is a rather daft question but I was wondering are those
> functions, along with Curl_pp_easy_statemach() in pingpong.c, still needed
> now or should we be fixing up the code to use the xxxx_multi_statemach()
> functions instead?

It is a fair question! I think perhaps we should consider renaming them since
they are no longer in fact used for driving any easy interface state machine.

They are however still used for a blocking-mode state machine: ftp_quit() is
the only user of ftp_easy_statemach() since it (still) relies on a synchronous
function to do the full request and response. The other protocols have similar
uses.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2013-01-18