lib/Makefile.m32 has this:

  ifdef ARES
    INCLUDES += -I"$(LIBCARES_PATH)"
    CFLAGS += -DUSE_ARES

But lib/config-win32.h has this:

  /* Define to enable c-ares asynchronous DNS lookups. */
  /* #define USE_ARES 1 */

  /* Define to enable threaded asynchronous DNS lookups. */
  #define USE_THREADS_WIN32 1

  #if defined(USE_ARES) && defined(USE_THREADS_WIN32)
  # error "Only one DNS lookup specialty may be defined at most"
  #endif

Shouldn't the Makefile.m32 take precedence over config-win32.h?
So the #ifdef could be:

  #ifndef USE_ARES
  /* Define to enable threaded asynchronous DNS lookups. */
  # define USE_THREADS_WIN32 1
  #endif

And since the package is called 'c-ares', why not rename this to
USE_CARES? The old ares doesn't work anymore according to
lib/README.ares.

BTW, a patch for that:

--- Git-latest\lib\README.ares 2013-01-07 02:56:35.046875000 +0100
+++ lib\README.ares 2013-01-10 14:13:19.538750000 +0100
@@ -13,7 +13,7 @@
 NOTE
   The latest libcurl version requires c-ares 1.6.0 or later.

- Once upon the time libcurl built fine with the "original" ares. That is no
+ Once upon a time libcurl built fine with the "original" ares. That is no
   longer true. You need to use c-ares.

 Build c-ares

--gv
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-01-10