On Fri, Jan 04, 2013 at 06:01:45PM +0100, Marc Hoersken wrote:
> Hi everyone,
>
> 2013/1/4 Yang Tse <yangsita_at_gmail.com>:
> > Hi,
> >
> > I've re-read all messages in this thread a couple of times, if you
> > wish to reply to this message, please, don't do it until you've read
> > it fully ...
>
> thanks for this summary, Yang.
>
> > Before pushing this reversion, I'm here asking you all to reconsider
> > existing situation and if reverting this change is what we actually
> > want now.
> >
> > So please, either way express yourselves again. I don't want to goof
> > it twice in a row.
>
> I now vote to keep the current situation including the new naming convention.
> In my opinion another commit reverting the changes would just make
> matters worse, as you already explained.

Note that git will skip over the double rename and show you history
between foo.c and foo.c, as if curl_foo.c never existed. I suspect that
github's web interface will do the same. Any work done between the
rename to curl_*.c and back will appear to be "lost". Looking at the
history between the rename yesterday and now, nothing in lib/ was
changed, so this is a non-issue if this remains the status quo until a
potential revert is pushed.

Aside from the "unsightly" change and revert that would introduce into
the history, I disagree that this makes anything "worse". Rather, it
restores the previous state fairly cleanly.

d
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-01-04