cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: hiperfifo2.cpp (was Re: curl-library Digest, Vol 88, Issue 49)

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 3 Jan 2013 00:31:54 +0100 (CET)

On Sun, 30 Dec 2012, Giuseppe Attardi wrote:

> Sorry, the file I submitted is the one using libevent, the version for
> libevent2 is enclosed here.

PLEASE stop the digest-mode of the list when you decide to actually
participate in discussions here. We use sensible subjects and we trim quotes
here...

Sorry, but I'll reject this example. First, I don't think it adds much extra
value compared to the already existing libevent example (and I disagree that
it is easier to read, but of course that is very subjective) but perhaps more
importantly I suspect that it is wrong!

Here's why: The way you use CURLOPT_PRIVATE and CURLINFO_PRIVATE look very
much as if you make the wrong assumption that the same easy handle will have a
one-to-one mapping with the socket in like the sock_cb() function. You will
get multiple sockets per easy handle, can your code handle that? Also, why
does it say say "Sending data" on what looks like the first call? Surely that
is more often misleading than actually correct?

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2013-01-03