Daniel Stenberg <daniel_at_haxx.se> wrote:

> On Sun, 18 Nov 2012, Fabian Keil wrote:
>
> > The attached patches (except for a typo fix) slightly modify various tests
> > to make using curl's test suite with external proxies more convenient.
>
> > At least some of them are also useful in general.

> Mailing patches individually that do CRLF changes is a tricky business and
> they are hard to get down the same way to have them stored locally. Can you
> try to make a tarball with them all and attach them and I'll see if the line
> endings might survive better all the way to me that way?

Oops. Looks like my MUA messed up the line endings before signing the mail.
I attached a tarball like you suggested.

> Can elaborate on how you test with "external proxies" and what was the problem
> you fixed here?

I'm using a couple of runtest.pl modifications that haven't all been
finished yet. I added them to the tarball as a "preview" (0010-0017).

With the patches applied, I test Privoxy like this:
./runtests.pl -n -P http://10.0.0.1:8118/ -H 10.0.0.1 -m curl-test-manifest-for-privoxy HTTP

The "problem" is that Privoxy by design accepts both header endings but
corrects it on the fly so the client will always receive correct endings.

I patched runtests.pl to deal with consistently missing carriage returns
(only in "proxy mode", of course), but it currently doesn't work if both
header endings are used for the same test. Changing this wouldn't be a big
deal, but as my impression was that the mixed header endings weren't
intentionally I haven't done that yet.

I'm currently only testing Privoxy (and already found a couple of issues),
but intend to add additional runtests.pl workarounds required to test Polipo
as well.

Fabian

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html