On Nov 16, 2012, at 7:33 AM, Daniel Stenberg <daniel_at_haxx.se> wrote:

> On Wed, 7 Nov 2012, Christian Vogt wrote:
>
>> idea of immediately re-sending the ACK packet for block X in case we receive block X data again while waiting for block X+1 was missing. So I created a patch against v7.28.0 that adds just this (see attachment).
>>
>> This finally solved my problem. Any chance to get this into the official releases?
>
> Thanks, merged and pushed now!

This patch broke the build with debug enabled:

../lib/tftp.c:594:8: warning: if with space first in condition
     if( NEXT_BLOCKNUM(state->block) == rblock ) {
        ^
../lib/tftp.c:598:13: warning: if with space first in condition
     else if( state->block == rblock ) {
             ^
../lib/tftp.c:599:85: warning: Longer than 79 columns
       /* This is the last recently received block again. Log it and ACK it again. */
[…]
libtool: link: ( cd ".libs" && rm -f "libcurlu.la" && ln -s "../libcurlu.la" "libcurlu.la" )
make[1]: *** [all] Error 2
make: *** [all-recursive] Error 1

Nick Zitzmann
<http://www.chronosnet.com/>

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2012-11-16