cURL / Mailing Lists / curl-library / Single Mail


Re: PATCH: gnutls: fix the error_is_fatal logic once and for all, hopefully (was: lib/gtls.c question about handshake())

From: Alessandro Ghedini <>
Date: Tue, 30 Oct 2012 23:19:56 +0100

On Wed, Oct 24, 2012 at 04:08:46PM +0200, Alessandro Ghedini wrote:
> On 10/24, Alessandro Ghedini wrote:
> > Attached is the patch that implements the second solution. I am testing it right
> > now to see if it works, so do not merge this yet.
> I've rewritten the patch to fix the original broken logic, so that it now still
> prints "gnutls_handshake() warning: ..." and has the correct behaviour (i.e.
> doesn't break git).
> The problem is that the original test case still fails a few steps afterwards
> with "GnuTLS recv error (-15): An unexpected TLS packet was received" and I
> don't know why. When manually sending the HTTP request using gnutls-cli it
> works fine.
> The second patch attached is for printing the actual content of the received
> TLS alert, so that libcurl prints the more useful:
> gnutls_handshake() warning: The server name sent was not recognized
> instead of:
> gnutls_handshake() warning: A TLS warning alert has been received.
> Comments?


Note that with "the original test case" I meant this:;filename=test_685402.c;att=2;bug=685402


perl -E '$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'

List admin:

Received on 2012-10-30