On Saturday, July 21, 2012 20:05:11 Fabian Keil wrote:
> That could happen either way.

True.

> I agree that dealing with LF terminators isn't particularly important,
> though. I mainly suggested it because doing it is easy and it's already
> done elsewhere.
>
> > Are you aware of any publicly available HTTTP server that would exercise
> > the code path above? This would need some testing I guess...
>
> I can't name any out of my head. I'd expect that some still exist,
> but given that pretty much no client requires the proper header
> termination they don't really stand out.

I usually tend to write workarounds only when necessary, with clear use case
and clear testing scenario. Blindly committing untested quirks just in case
has caused me a lot of bad surprises already.

Nevertheless, I believe that your proposal is relatively safe. Please have
a look at the updated version of the patch. Thanks!

Kamil
Received on 2012-07-21