cURL / Mailing Lists / curl-library / Single Mail

curl-library

a sasl warning

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sat, 2 Jun 2012 23:08:22 +0200 (CEST)

Hi Steve,

Since Curl_ntlm_sspi_cleanup() is defined to nothing on some systems we get a
warning in curl_sasl.c and I was thinking perhaps we can add something like
the following to avoid the warning:

curl_sasl.c:195:44: error: unused parameter 'conn' [-Werror=unused-parameter]

The patch that works for me and I think would work on windows as well:

diff --git a/lib/curl_sasl.c b/lib/curl_sasl.c
index e9a3c18..407386d 100644
--- a/lib/curl_sasl.c
+++ b/lib/curl_sasl.c
@@ -198,10 +198,12 @@ void Curl_sasl_cleanup(struct connectdata *conn,
unsigned int auth
    /* Cleanup the ntlm structure */
    if(authused == SASL_AUTH_NTLM) {
      Curl_ntlm_sspi_cleanup(&conn->ntlm);
+ (void)conn; /* avoid warnings on systems where Curl_ntlm_sspi_cleanup()
+ is just a nop */
    }
  #else
    /* Reserved for future use */
    (void)conn;
    (void)authused;

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2012-06-02