cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Issue with partial file transfer

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 19 Apr 2012 22:13:26 +0200 (CEST)

On Thu, 19 Apr 2012, Grzegorz Sikorski wrote:

> I have made some patch in lib/ftp.c file in function ftp_state_ul_setup.
> Here is a diff:

Isn't the diff reversed?

> Let me know if you think that is OK. I tested it and it works also in 4 case
> described in previous message.

It is not OK since it changes behavior for existing application in a very
drastic way.

In general libcurl doesn't seek for anything where there's no need for it to
seek, it only seeks when it has done something within the request that has
moved the file position forward and it needs to put it back.

In your case, libcurl has not moved the file position to start with.

I would much rather have us make this clearer in the documentation somehow!

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2012-04-19