Hi,

>0 - if you would've written a test case for this, we would've trapped
> this mistake immediately with valgrind and friends

I'll look into how to do this the next time.

>1 - it didn't apply to the git repo code (I had to modify your previous patch
> when I accepted that)

I kinda figures. I'm not using git code, but a released version of cURL. That's why I mentioned for what code was the patch made.

>2 - we need C89 compliant code: first variable declarations then code.

Then you should also change the orgininal code of that function (i.e. the else branch). Nevertheless, I'll keep that in mind for future submits.

>3 - please consider making a local git commit with proper commit message and
> author set correctly and extract it with 'git format-patch'.
> That way makes it *much* easier for me to 'git am' your work with less
> manual work for me.

Andrei

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2012-03-22