Hi Dan,

> > I would appreciate it if you, Dan and anyone else who is interested
> > could give the following list a little review. The list contains all
> > the proposed command line arguments for all POP3 commands. I have only
> > grouped them for easy of reading here, the code I have written doesn't
> > treat them any differently (and in fact I have managed to keep the
> > existing list and retr response functions, dropping the list single
function).

[cut]

> This looks great to me!

Cheers for the feedback Dan - it is much appreciated.

> > Obviously if a user was to specify the mailbox in the URL and perform
> > -X "DELE 1" the mailbox in the URL is currently ignored. We could
> > append the mailbox to the custom command which might be useful for
> > LIST, UIDL and DELE but that would cause problems for TOP as you NEED
> > to specify either 0 for "Just the headers" or the number of lines
> > required from the message - However I am flexible here so any opinions
> > would be appreciated.
>
> We could still unconditionally append the mailbox in the URL to the
command,
> if it's present. So, delete could be done by either:
>
> --url pop3://mail.domain.com -I -X "DELE 1"
>
> or
>
> --url pop3://mail.domain.com/1 -I -X DELE

At present I don't inspect the contents of the custom command, which means
that 1) The user is free to send utter rubbish e.g --url
pop3://mail.domain.com -I -X "UTTER RUBBISH" and the server will response
with an appropriate error code and 2) Appending the mailbox to the command
would work for DELE but the same code would then send "TOP 1 0 1" for --url
pop3://mail.domain.com/1 -I -X "TOP 1 0" unless we tried to insert the
mailbox between "TOP" and the number of rows. I'm happy to implement the
simple append but it may be a little confusing.

I've pretty much finalised the code, so I will start pushing some fixes and
pre-feature clean ups come next week after the release of v7.25 and then I
will post the changes here for review.

Kind Regards

Steve

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2012-03-14