cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH] pop3.c: Fixed drop of final CRLF in EOB checking

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 20 Feb 2012 23:56:46 +0100 (CET)

On Mon, 20 Feb 2012, Steve Holme wrote:

> The logs confused me to begin with as I was expecting to see "0d 0a" between
> each line rather than just 0a. Is that by design / a flaw of the test
> scripts when running under linux or is it intentional?

No, it is actually just how the test data is written. The test file is using
unix newlines and there are no additional [CR]s added so they are just [LF].

That's actually not relevant to this test as I get the exact same failure even
if I make them CRLF all the way.

> I also wouldn't expect to see an extra CRLF as such, though I guess you
> could argue it depends on whether the sending application is adding the CRLF
> at the beginning of the EOB or not.

Yes, and that's the problem here I think. The test/ftpserver.pl is what sends
the response to the POP3 RETR command (see the RETR_pop3 function) and it
sends everything within the <data> and then a trailing "\r\n.\r\n" sequence.

If I understand you correctly, that terminating string should only be ".\r\n".
Right?

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2012-02-20