cURL / Mailing Lists / curl-library / Single Mail

curl-library

[PATCH] curl tool: allow negative numbers as option values

From: Alessandro Ghedini <al3xbio_at_gmail.com>
Date: Sun, 12 Feb 2012 14:49:32 +0100

Fix the str2num() function to not check if the input string starts with a
digit, since strtol() supports numbers prepended with '-' (and '+') too.
This makes the --max-redirs option work as documented.

---
 src/tool_paramhlp.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/tool_paramhlp.c b/src/tool_paramhlp.c
index adb12ce..2d8e7f0 100644
--- a/src/tool_paramhlp.c
+++ b/src/tool_paramhlp.c
@@ -151,8 +151,6 @@ void cleanarg(char *str)
  * Parse the string and write the integer in the given address. Return
  * non-zero on failure, zero on success.
  *
- * The string must start with a digit to be valid.
- *
  * Since this function gets called with the 'nextarg' pointer from within the
  * getparameter a lot, we must check it for NULL before accessing the str
  * data.
@@ -160,7 +158,7 @@ void cleanarg(char *str)
 
 int str2num(long *val, const char *str)
 {
-  if(str && ISDIGIT(*str)) {
+  if(str) {
     char *endptr;
     long num = strtol(str, &endptr, 10);
     if((endptr != str) && (endptr == str + strlen(str))) {
-- 
1.7.9
--fdj2RfSjLxBAspz7
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
--fdj2RfSjLxBAspz7--
Received on 2001-09-17