cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: PATCH: Improve output of curl's --libcurl option

From: Colin Hogben <curl_at_pythontech.co.uk>
Date: Tue, 27 Dec 2011 22:38:02 +0000

On 25/12/2011 23:34, Daniel Stenberg wrote:
> If
> I would point out a very minor flaw in the readability of the output it
> would be that it interleaves the curl_formadd() calls within the seires
> of curl_easy_setopt() calls. It would possibly look better if they were
> made separate of each other.

Maybe; there are few other improvements I could make too, but maybe not
this week.

> CURLOPT_SSH_KNOWNHOSTS is used conditionally and needs to be stripped
> out from the test output before comparing. I'm working on that.

OK, I'll leave that to you.

>> ... I really ought to check that the generated code
>> really does work the same as the curl tool with the given options.

>> For the moment, I have not released this but only used it within my
>> own tree,

> If you post what you have this far with a basic description then I think
> I can give a shot at doing the proper autotool massaging to get it used
> properly!

See the attached patch. Example use would be:

  ./convsrctest.pl -c data/test1400 > libtest/lib1500.c
  ./convsrctest.pl -test=1500 data/test1400 > data/test1500

Regards,

-- 
Colin
Received on 2011-12-27