cURL / Mailing Lists / curl-library / Single Mail


Re: [RFC PATCH] symbols versioning

From: Daniel Stenberg <>
Date: Thu, 15 Dec 2011 17:56:35 +0100 (CET)

On Wed, 14 Dec 2011, Alessandro Ghedini wrote:

> in Debian we have been carrying for quite some time a patch that allows, at
> configuration time, the "production" of versioned symbols for the different
> flavours of SSL libraries supported [0]. It was even submitted for merging
> at some point [1] and Daniel showed some interest and also presented some
> remarks but apparently it all ended there (i.e. the patch was not merged).

There was never any updates presented so my objections remained...

> At this point the patch is not in a much better state then it was at the
> time, but before starting to work on it to get it in shape, I'd like to know
> if there is still some interest in it. Are there any chances it will be
> merged, premised that all the problems get fixed?

Sure, this option seems harmless for uninterested users and it could be useful
for some, so I could indeed see it getting merged.

My comments on this generation of the patch:

1 - The warning on line 22-23 seems to assume that --with-gnu-ld can be used
     which we really cannot know. I suggest a more generic error message that
     will work even for non-gnu compilers and linkers.

2 - The condition on line 56 needs to be modified to not evaluate a blank
     string. Like this:

     AM_CONDITIONAL(VERSIONED_SYMBOLS, test "x$versioned_symbols" = "xyes")

3 - lib/ would need to be added to lib/ to get
     shipped in release tarballs

List admin:
Received on 2011-12-15