On Thu, 15 Dec 2011, Gokhan Sengun wrote:

> 1- I plan to introduce another timeout in addition to TRANSFER timeout and
> CONNECT timeout. It could be called ACCEPT_TIMEOUT and meaningful only for
> active FTP data connections. When server says 150 but then says nothing
> (like 421, 425 or 426), we may wait this timeout and then fail with
> ACCEPT_TIMEOUT error. This means we have to introduce another error like
> CURLE_ACCEPT_TIMEOUT

Sounds perfectly sensible to me.

> 2- I tried to run the tests 591 through 594. Some tests still fails because
> of the expected return code and some fails because they expect QUIT command
> be sent even if timeout occurs.

That's why they are still in the DISABLED file! The test cases should be
updated though and not expect QUIT as internally we give up control
connections on all kinds of timeout errors.

> server sends 150 afterwards sends 4xx meaning it was not able to connect to
> the client because of an internal error. In this case what error code should
> be used? A new error code like CURLE_SERVER_FAILED_TO_CONNECT orr
> CURLE_FTP_COULDNT_RETR_FILE or CURLE_FTP_COULDNT_STOR_FILE.

How about CURLE_FTP_PORT_FAILED ?

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html