cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH] POP3: fixed escaped dot not being striped out

From: Daniel Stenberg <>
Date: Thu, 1 Dec 2011 11:07:21 +0100 (CET)

On Wed, 30 Nov 2011, Steve Holme wrote:

> Please find attached a patch that corrects escaped full stop characters
> (dots) at the beginning of new lines.
> The patch is based around Daniel's reworking of the eob detection, however,
> rather than allocate new buffers and memcpy the content around I have
> extended the detection to be whole buffer based rather than just the last 5
> characters. This will slow incoming mail down but I can't think what else we
> can do.

Excellent! I had a go at a similar approach but it turned out messy and so
complicated I had to ditch it. Your take looks much better than what I ended
up with.

I've now fixed and extended test case 815 and used that to verify your patch
and it performed as expected.

I'll commit and push your patch soon.

List admin:
Received on 2011-12-01