cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] add support for pkg-config detection of libidn

From: Yang Tse <yangsita_at_gmail.com>
Date: Mon, 28 Nov 2011 13:14:31 +0100

2011/11/25 Mark Brand wrote:

>        if test "x$idn" != "xyes"; then
> +         dnl check with pkg-config
> +         PKG_CHECK_MODULES(LIBIDN_PC, libidn >= 0.0.0, [idn=yes], [idn=no])
> +         if test "x$idn" = "xyes"; then
> +            LIBS="$LIBS $LIBIDN_PC_LIBS"
> +            CPPFLAGS="$CPPFLAGS $LIBIDN_PC_CFLAGS"
> +         fi
> +       fi
> +
> +       if test "x$idn" != "xyes"; then

This patch would introduce for the first time usage of macro
PKG_CHECK_MODULES in libcurl's configure script. If this macro is used
then it introduces an additional prerequisite in order to be able to
generate libcurl's configure script which didn't exist up to now.

With this macro in place buildconf _requires_ that proper m4 macros
from pkg-config can be located and used by the buildconf script. IOW
it requires pkg-config properly installed and operative for the target
you want to build even before configure has a chance of running its
first line of code.

Up to now libcurl configure script could be 'bootstrapped' on systems
which lacked pkg-config support or did not want to have it installed
due to other problems it carries along (lack of cross-compilation
support, lack of multi-ABI support, unexpected reordering of
libraries)

Given the yet immature status of pkg-config the dependency would
always be on the very last released version of pkg-config.

PKG_CHECK_MODULES brings a lot of support grief for no additional
benefit. pkg-config info can still be used in the same way as
libcurl's configure script does for other libraries without needing
this macro.

My 2cents, avoid PKG_CHECK_MODULES usage.

-- 
-=[Yang]=-
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2011-11-28