curl-library
Re: query part for non-HTTP(S) URLs
Date: Tue, 22 Nov 2011 12:38:04 +0100
>
>> Hi Guys,
>>
>>>> I have a much better feeling when the cut off is only on the file proto.
>>>
>>> Why? What about FTP(S), IMAP(S), POP3(S), TELNET and SMTP(S)? I
>>> think we're pretty sure that they don't use the query part. I would think
>>> RTMP also don't, but we can let the ones we're unsure of remain untouched.
>>
>> I just wanted to add my two pennies worth as I've been doing quite a bit of
>> work in the SMTP and POP3 areas recently as well as adding to the docs
>> regarding the file part of the URL.
>>
>> SMTP doesn't use the query part and it is pretty safe to assume it won't in
>> the future either.
>>
>> However, I can't say the same for POP3 - as the protocol is pretty limited
>> at present. POP3 desperately needs support for the delete command as well as
>> a few other commands and this may well be / could be done by using the query
>> part of a URL at some point eg. pop3://mail.domain.com/delete?msg=1.
>>
>> I don't really want to get into a discussion about the future of POP3 at
>> present but all I wanted to highlight is that I would like to see the
>> ability to quite quickly enable or disable the query part for specific
>> protocols... maybe like Daniel suggested, via a bit in the protocol handler.
>>
>
> Okay. I think you and Daniel are right.
> Via protocol header bit sounds much more flexible.
> I try to implement this.
>
> On which protocols we do cut of the query part we can also decide later.
>
> Maybe we do a small "table":
> DICT -> cut query
> FILE -> cut query
> FTP -> cut query
> FTPS -> cut query
> GOPHER -> NO CUT
> HTTP -> NO CUT
> HTTPS -> NO CUT
> IMAP -> NO CUT
> IMAPS -> NO CUT
> LDAP -> NO CUT
> LDAPS -> NO CUT
> POP3 -> NO CUT
> POP3S -> NO CUT
> RTMP -> cut query
> RTSP -> cut query
> SCP -> cut query
> SFTP -> cut query
> SMTP -> cut query
> SMTPS -> cut query
> TELNET -> cut query
> TFTP -> cut query
> (suggestion)
>
>
And here comes the patch with a proper protocol header flag bit.
Currently added only to the file:// protocol.
As soon as we decided on the table above, i'll finish the implementation and write more tests.
Patch: feel also free to fix my bad english in the source code comments. :)
</jonas>
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
- application/octet-stream attachment: patch_commit_5d29d76593df.patch