cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: PATCH: Do not allow multi interface to block trying to perform DNS on interface names

From: Jason Glasgow <jglasgow_at_google.com>
Date: Thu, 17 Nov 2011 21:32:03 -0500

On Thu, Nov 17, 2011 at 5:09 PM, Daniel Stenberg <daniel_at_haxx.se> wrote:

> On Tue, 8 Nov 2011, Jason Glasgow wrote:
>
> I have added if! and host! prefix processing and below is a refined patch.
>>> Comments welcome.
>>>
>>
> It looks great!
>
> o There's an unused variable:
> if2ip.c:79:9: error: unused variable 'ip' [-Werror=unused-variable]
>
> o I'll appreciate an edited documentation as well that reflects this news
>
> o Have you given the test side some consideration?
>
> --
> / daniel.haxx.se
> ------------------------------**------------------------------**-------
>
Glad the approach looks right. I will fix the error, work on some
documentation and try to figure out how to test. I will resend a patch as
soon as I can get these additional things sorted out. Thanks for the
feedback. -Jason

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-11-18